Upgrade playground Playwright to 1.62.1; e2e on @next (Firefox r1544) - #318
Merged
Conversation
mxschmitt
marked this pull request as ready for review
September 3, 2026 19:14
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bump Playwright workers, editor types, and npm packages via update_pw.mjs. Co-authored-by: Max Schmitt <max@schmitt.mx>
…itor 0.56 TypeScript 7 removes node10 module resolution and esModuleInterop=false. Monaco 0.56 remaps package exports, so worker and API imports need the new paths. Co-authored-by: Max Schmitt <max@schmitt.mx>
Playwright 1.62 ships Firefox 153, which crashes the tab when Monaco creates its TypeScript language worker a second time after navigation. Skip that worker (and extra libs) on Firefox, dispose the editor on unload, and keep monaco-editor on 0.55.1. Co-authored-by: Max Schmitt <max@schmitt.mx>
E2E and frontend component tests stay on Playwright 1.60 (Firefox 150) to avoid the Firefox 153 worker-reload SIGSEGV. Worker images, editor types, and the README badge remain on 1.62.x. Co-authored-by: Max Schmitt <max@schmitt.mx>
cursor
Bot
force-pushed
the
cursor/upgrade-playwright-4443
branch
from
September 4, 2026 21:58
2f58c4f to
6a49dff
Compare
cursor
Bot
changed the title
E2E stays on @playwright/test 1.60 (Firefox 150), so the share-reload SIGSEGV does not apply to CI. Production Firefox 153+ can still hit microsoft/playwright#42565 on reload while the worker compiles. Co-authored-by: Max Schmitt <max@schmitt.mx>
microsoft/playwright#42631 is on @next, not 1.63.0. Frontend CT stays on 1.62.1 because experimental-ct-react has no matching 1.64 package. Co-authored-by: Max Schmitt <max@schmitt.mx>
cursor
Bot
changed the title
npm ci with experimental-ct-react 1.62.1 nests playwright, so tsc cannot resolve playwright/test from App/index.spec.tsx during the Docker npm run build. Co-authored-by: Max Schmitt <max@schmitt.mx>
The channel API currently presents a self-signed certificate, so the installer fell back to tag "stable" and the test job never ran e2e. Co-authored-by: Max Schmitt <max@schmitt.mx>
Test Results SummaryThis comment shows the latest test results for this pull request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playground workers, types, and README stay on Playwright 1.62.x. E2E tests now use
@playwright/test@next(1.64.0-alpha-2026-09-10) so they pick up Firefox r1544 from microsoft/playwright#42631, which is not inlatest(1.63.0 / firefox-1543).That Firefox roll is the fix for the Monaco
ts.workerSIGSEGV on share+reload (microsoft/playwright#42565). The Editor no longer special-cases Firefox.Frontend component tests stay on
@playwright/experimental-ct-react@1.62.1. There is no matching CT package on the 1.64 alpha line, and overridingplaywright-coreto 1.64 while CT is 1.62 breaks Vite transform (?raw/ CSS modules).Pinned the e2e version to the resolved
@nextdist-tag rather than the floatingnextrange so CI stays reproducible until 1.64 ships.Frontend production
tscnow excludes*.spec.ts(x)so the Docker image build does not typecheck CT tests. After the 1.62.1 lockfile,playwrightis nested under@playwright/experimental-ct-core, which madeimport type { Page } from 'playwright/test'failnpm run build.CI installs k3s v1.36.4+k3s1 (same release last green
testjob used) so the installer does not queryupdate.k3s.io, which currently presents a self-signed certificate and caused the test job to fail before e2e ran.Test plan
npm installine2e/resolvesplaywright-core1.64.0-alpha with Firefox revision 1544cd frontend && npm run build(tsc && vite build)build (frontend)Docker image